-
Notifications
You must be signed in to change notification settings - Fork 82
Rad & acid resistance tags #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Acid is here: AlexsCaves/src/main/java/com/github/alexmodguy/alexscaves/server/block/AcidBlock.java Line 77 in ed44361
|
|
Thank you, line 62 was what I was looking for. That's where the check for the hazmat armor is. |
|
I ran some tests on the new way the radiation and acid protection is handled in these commits and there are no issues I can find. Applying the tags with KubeJS showed no issues with applying the resistances. Removing the tags showed no issues properly removing the resistances. Items, blocks, fluids and mobs do not change their behavior as a result of this. |
src/main/java/com/github/alexmodguy/alexscaves/server/block/AcidBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/alexmodguy/alexscaves/server/item/HazmatArmorItem.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/alexmodguy/alexscaves/server/misc/ACTagRegistry.java
Outdated
Show resolved
Hide resolved
Updates naming of tags and shit to make more sense.
|
There, that should be better. I made sure to search through the project to double check that nothing was using an old variable name so the changes don't break stuff. |
fix AlexModGuy#1464 in upstream
Setup for a test.
|
I don't know how to draft PRs but its almost 3 am and i do not have the brain power to figure out how this weird properties system works and how to convert it to using tags or something else that anyone can edit. |
gotta remember what they mean, after all
hopefully i actually use these
hopefully this works, i don't usually contain tags inside a tag
I don't know if I need to create this tag since nothing uses it, but the registry is black magic to me so better safe than sorry.
god interpreting these into radiation values is going to be a pain probably...
Might be better to reference the block tag instead of each block, but IMO the more configurability, the better.
|
All that's left to allow giving blocks and items radioactivity through tags is RadioactiveBlockItem, RadioactiveOnDestroyedBlockItem and RadioactiveItem. I don't know how they work yet, so that might take a while. |
covered by the new mixin. still required by the ondestroyed function.
think i accidentally pressed "replace all"
|
All that's left to implement is the functionality of RadioactiveOnDestroyedBlockItem using tags. Unfortunately I need to do something different from the other two since my idea, which is attached, didn't work. |
So much hoping here.
It looks like I got this to work but I honestly have no clue because I'm not sure how it works originally. |
For the sake of compatibility, I have edited how radiation works to allow armor resistance to be done using a tag instead of an item ID. Acid behaves the same and radiation still functions the same. The tag is applied to the hazmat suit by default. Acid does not have a resistance tag because I couldn't figure out where the code that gives the hazmat suit resistance is.
When this gets merged, feel free to revert the change to the build.gradle file. I did that since I made an upload to CF, which I will archive if this gets merged, and if I didn't change the name, it would've broken some addons.