Repository navigation
Conversation
Owner
|
Thank you for your PR. It looks good, but can you please add a test for this case which will fail in master branch and pass in your branch? |
Author
|
I noticed there are still other problems,.. And, I have an excel with numbers, but numbers are not read.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #22
it's because of the following codes
https://github.com/jsonkenl/xlsxir/blob/master/lib/xlsxir.ex#L602
and we don't have this :info key when we load xls files
and the infinite loop problem is because of
https://github.com/jsonkenl/xlsxir/blob/master/lib/xlsxir.ex#L510
the if condition never meets and an infinite loop happens
we can change
next_ref == totonext_ref >= toto enhance robustnessbut the root cause is because our cell order of a row in ets differs from the cell order of xlsx format
ets contents of a xlsx file parsed by Xlsxir
ets contents of a xls file parsed by Exoffice