Skip to content

Fix GitHub Pages Vite deployment#2

Merged
AlexKitipov merged 1 commit into
mainfrom
codex/fix-github-pages-deployment-issues
Jun 9, 2026
Merged

Fix GitHub Pages Vite deployment#2
AlexKitipov merged 1 commit into
mainfrom
codex/fix-github-pages-deployment-issues

Conversation

@AlexKitipov

Copy link
Copy Markdown
Owner

Motivation

  • Remove competing Jekyll builds that can interfere with the Vite build artifact deployment to GitHub Pages.
  • Ensure GitHub Pages does not attempt Jekyll processing of the uploaded dist artifact.
  • Make sure public static files such as CNAME are copied into dist so the Pages artifact includes site metadata.

Description

  • Deleted the Jekyll workflows .github/workflows/jekyll-docker.yml and .github/workflows/jekyll-gh-pages.yml so only the Vite-based Pages workflow runs.
  • Added repository-level .nojekyll and public/.nojekyll marker files so the deployed artifact disables Jekyll processing.
  • Updated vite.config.ts to explicitly set publicDir: 'public' so public/ contents (including CNAME and .nojekyll) are copied into dist.
  • Left the existing Vite Pages workflow (.github/workflows/deploy-github-pages.yml) as the deployment path which verifies dist/CNAME and uploads dist as the Pages artifact.

Testing

  • Ran npm run ci:quality, which runs eslint, tsc --noEmit, the test runner, and vite build, and the pipeline completed successfully.
  • Unit tests reported 9/9 tests passed during the test run.
  • Verified the build produced dist/CNAME and dist/.nojekyll via test -f dist/CNAME && test -f dist/.nojekyll, which succeeded.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96680c9de2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vite.config.ts
build: {
outDir: 'dist',
},
publicDir: 'public',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve deployed legacy archive assets

When the Jekyll Pages workflow is removed, this Vite artifact becomes the only deployed site, but the build only uploads dist and Vite copies public/ assets, not docs/legacy/. I verified npm run build produces no dist/docs/legacy/index.html, while the app still renders a public project link to /docs/legacy/index.html in src/data/projects.ts, so the “Legacy Learning Archive” link will 404 in production unless those archived files are copied into the artifact or the link is removed/changed.

Useful? React with 👍 / 👎.

@AlexKitipov AlexKitipov merged commit b7921a6 into main Jun 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant