Fix GitHub Pages Vite deployment#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96680c9de2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| build: { | ||
| outDir: 'dist', | ||
| }, | ||
| publicDir: 'public', |
There was a problem hiding this comment.
Preserve deployed legacy archive assets
When the Jekyll Pages workflow is removed, this Vite artifact becomes the only deployed site, but the build only uploads dist and Vite copies public/ assets, not docs/legacy/. I verified npm run build produces no dist/docs/legacy/index.html, while the app still renders a public project link to /docs/legacy/index.html in src/data/projects.ts, so the “Legacy Learning Archive” link will 404 in production unless those archived files are copied into the artifact or the link is removed/changed.
Useful? React with 👍 / 👎.
Motivation
distartifact.CNAMEare copied intodistso the Pages artifact includes site metadata.Description
.github/workflows/jekyll-docker.ymland.github/workflows/jekyll-gh-pages.ymlso only the Vite-based Pages workflow runs..nojekyllandpublic/.nojekyllmarker files so the deployed artifact disables Jekyll processing.vite.config.tsto explicitly setpublicDir: 'public'sopublic/contents (includingCNAMEand.nojekyll) are copied intodist..github/workflows/deploy-github-pages.yml) as the deployment path which verifiesdist/CNAMEand uploadsdistas the Pages artifact.Testing
npm run ci:quality, which runseslint,tsc --noEmit, the test runner, andvite build, and the pipeline completed successfully.9/9 tests passedduring the test run.dist/CNAMEanddist/.nojekyllviatest -f dist/CNAME && test -f dist/.nojekyll, which succeeded.Codex Task