Skip to content

Fix unsound transmute_copy use #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix unsound transmute_copy use #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions message-passing-framework/src/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ impl<T: MessageKind> Message<T> {
let byte_slice: &[u8] = std::slice::from_raw_parts(byte_ptr, std::mem::size_of::<V>());

std::ptr::copy(
&byte_slice[0],
byte_ptr,
self.body.as_mut_ptr().offset(i as isize),
std::mem::size_of::<V>(),
);
Expand All @@ -63,10 +63,7 @@ impl<T: MessageKind> Message<T> {
let i = self.body.len() - bytes;

let out = unsafe {
let data_ptr = self.body.as_ptr().offset(i as isize);
let byte_slice: &[u8] = std::slice::from_raw_parts(data_ptr, bytes);

std::mem::transmute_copy(&byte_slice[0])
self.body.as_ptr().offset(i as isize).cast::<V>().read_unaligned()
};

self.body.resize(i, 0);
Expand Down Expand Up @@ -112,7 +109,7 @@ impl<T: MessageKind> From<&[u8]> for Message<T> {
panic!("no, this is not header");
}

let header: MessageHeader<T> = unsafe { std::mem::transmute_copy(&bytes[0]) };
let header: MessageHeader<T> = unsafe { bytes.as_ptr().cast::<MessageHeader<T>>().read_unaligned() };

if header.size != bytes_len as u32 {
panic!(
Expand Down