Add content definitions module #3262
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3262 +/- ##
==========================================
- Coverage 97.14% 97.11% -0.03%
==========================================
Files 279 280 +1
Lines 7378 7388 +10
==========================================
+ Hits 7167 7175 +8
- Misses 211 213 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
definitions-module
branch
from
39bb57b to
317d6b7
Compare
tvdeyen
force-pushed
the
definitions-module
branch
3 times, most recently
from
6becdc7 to
502f3ab
Compare
tvdeyen
force-pushed
the
definitions-module
branch
3 times, most recently
from
acd859c to
2ed70b9
Compare
tvdeyen
force-pushed
the
definitions-module
branch
from
2ed70b9 to
1f800f4
Compare
|
This pull request has not seen any activiy in a long time. |
tvdeyen
force-pushed
the
definitions-module
branch
from
1f800f4 to
78e9e2b
Compare
tvdeyen
force-pushed
the
definitions-module
branch
2 times, most recently
from
3834854 to
7383854
Compare
tvdeyen
force-pushed
the
definitions-module
branch
3 times, most recently
from
e1e954d to
955a712
Compare
tvdeyen
force-pushed
the
definitions-module
branch
2 times, most recently
from
dbdf707 to
17f8267
Compare
tvdeyen
force-pushed
the
definitions-module
branch
3 times, most recently
from
3d089ac to
e1c7ed4
Compare
tvdeyen
force-pushed
the
definitions-module
branch
from
e1c7ed4 to
d198a96
Compare
| <li> | ||
| <header> | ||
| <strong><%= Alchemy::Ingredient.translated_label_for(ingredient_definition.role, element_name) %></strong> | ||
| <small><%= Alchemy::Ingredient.normalize_type(ingredient_definition.type).constantize.model_name.human %></small> |
Check warning
Code scanning / Brakeman
Unsafe reflection method constantize called on model attribute. Warning
Makes it much easier to choose the right element
Helps to visualize the usage of the page.
This is the know icon and only if we have a custom icon we should change it.
Determines the icon name for an element based on its name. Can be configured via +Alchemy.config.element_icon_finder+. The default implementation uses simple pattern matching on remixicon names.
tvdeyen
force-pushed
the
definitions-module
branch
from
d198a96 to
e148eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Describe you pull request here...
Closes # (Remove if not related to any issue)
Notable changes (remove if none)
Explain any changes (maybe breaking?) that have been made.
Screenshots
Remove if no visual changes have been made.
Checklist