Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow rule creation in sample.dnr-rule-manager when no rule exists (G…
…oogleChrome#1029) The `functional-samples/sample.dnr-rule-manager` example allows the user to add and remove `chrome.declarativeNetRequest` rules on demand from the extension's options page. Rules require to have a unique `id`, so the extension fetches the list of all the currently defined rules, takes the max and adds 1. When no rule is defined, this results in `Math.max(...[]) + 1` => `Math.max() + 1` => `-Infinity + 1` => `-Infinity` and since the `id` should be an integer and not an number, the extension throws an error. Ensuring that `0` is always a parameter of `Math.max` should solve the problem.
- Loading branch information