Fix key prefix config name in README - #797
Merged
Merged
Conversation
tvainika
approved these changes
May 26, 2026
tvainika
enabled auto-merge
May 26, 2026 09:02
tvainika
disabled auto-merge
May 26, 2026 09:02
ivanyu
approved these changes
Jun 1, 2026
Contributor
|
Will close and reopen to try to trigger the CI as I can't find the GH action. |
Contributor
|
Thanks @mmaroli! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
rsm.config.storage.key.prefixtorsm.config.key.prefix.The key prefix config is on the
RemoteStorageManagerConfiglevel so it's not prefixed with the storage prefix. If we use the example config in the README the key prefix isn't picked up and we write to the root path of the bucket.