Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide cursor on keyboard key press. #85

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

Penguin-Guru
Copy link
Contributor

This seems to work. Feel free to make any changes you want or let me know and I'll do what I can. 🙂

Copy link
Owner

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me overall, I'd just like to rename the flag, plus a couple of nits. Please do ping me again when you've amended the commit so I get notified.

src/unclutter.c Outdated Show resolved Hide resolved
src/event.c Outdated Show resolved Hide resolved
man/unclutter-xfixes.man Outdated Show resolved Hide resolved
@Penguin-Guru
Copy link
Contributor Author

@Airblader Is this how we ping people on GitHub? 😁

I've made the changes you suggested, with one slight difference in the manual entry. I commented on your suggestions above so you can read my thoughts. If you want any more changes, just let me know.

Copy link
Owner

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a few days, currently on vacation so couldn’t get to it right away. Thanks for making the changes!

@Airblader Airblader merged commit 0eb7a8f into Airblader:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants