Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use autotools #51

Closed
wants to merge 1 commit into from
Closed

Conversation

brgl
Copy link

@brgl brgl commented Sep 13, 2019

I'd like to add support for this project to yocto. In order to allow for easy cross-compilation this patch proposes to use autotools instead of a handcoded Makefile as a standard way of building. All the files are still installed as before.

@Airblader
Copy link
Owner

Thanks for the PR, this sounds great! The Travis configuration needs to be adjusted as well, let's get it done and we can merge this. :-)

@brgl brgl force-pushed the topic/autotools-build branch from fe07e6a to 4ffa95e Compare September 13, 2019 09:42
@brgl
Copy link
Author

brgl commented Sep 13, 2019

I don't really know travis - I've added some changes to travis.yml, but it doesn't seem to work. Could you help with this?

@Airblader
Copy link
Owner

After your changes to the Travis configuration, it now fails with undefined references to seemingly just anything related to X11 or libev, so my feeling is that this is a linking issue with the autotools setup, Travis itself runs fine now. I'm not really versed in autotools, so I cannot say much about that.

@brgl
Copy link
Author

brgl commented Sep 13, 2019

Strange, it builds for me locally as well as in yocto with this patch applied. I'll take a closer look then.

@brgl brgl force-pushed the topic/autotools-build branch 3 times, most recently from 23911c4 to 6f2a0cb Compare September 13, 2019 12:20
This removes the hand-crafted Makefile in favor of standardized autotools
build configuration. This is done to allow for easy cross-compilation of
this project.

Signed-off-by: Bartosz Golaszewski <[email protected]>
@brgl brgl force-pushed the topic/autotools-build branch from 6f2a0cb to 7be29dd Compare September 13, 2019 12:23
@brgl
Copy link
Author

brgl commented Sep 13, 2019

So it compiles fine and then the linkage fails: gcc -D'__VERSION="1.6"' "-I../include" -std=gnu99 -Wall -Wundef -Wshadow -Wformat-security -g -O2 -lev -lX11 -lXi -lXfixes -o unclutter cursor.o event.o extensions.o unclutter.o util.o as if the libraries couldn't be found. Strange, the X11 libs use pkgconfig in my configure.ac.

@Airblader Airblader closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants