Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to transpile Monica_SoilTemp Crop2ML code into all other frameworks and languages #217

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

bergm
Copy link
Contributor

@bergm bergm commented Nov 8, 2023

Hello Cyrille,

I finally managed to look into the code and fix the small issue to compile our Crop2ML code into the other languages. This shouldn't break anything. But who knows. :-)

Cheers,
Michael

@pradal
Copy link
Contributor

pradal commented Nov 8, 2023

Thanks Michael,
We will review it soon before merging!
Thanks

Copy link
Contributor

@pradal pradal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.
There is just one case (with java) that have to be managed.
Otherelse, everything is OK

src/pycropml/code2nbk.py Show resolved Hide resolved
@@ -245,7 +245,7 @@ def generate_test(self, model_unit):

ins = inouts['inputs']
outs = inouts['outputs']
print(outs.keys())
#print(outs.keys())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to remove print, thks

@pradal pradal merged commit 4d117c7 into AgriculturalModelExchangeInitiative:master Nov 8, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants