Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove an inadvertent test.only addition #8187

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

Chris-Hibbert
Copy link
Contributor

Description

I just noticed that #7868 introduced a test.only inadvertently. This removes it to re-expose the other tests there.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

I have a grep for test.only in my standard pre-submit, but I have to run it manually.

Upgrade Considerations

None.

@Chris-Hibbert Chris-Hibbert added bug Something isn't working code-style defensive correctness patterns; readability thru consistency labels Aug 14, 2023
@Chris-Hibbert Chris-Hibbert requested a review from turadg August 14, 2023 16:57
@Chris-Hibbert Chris-Hibbert self-assigned this Aug 14, 2023
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning #4981 here to add to reasons to do it :)

@Chris-Hibbert Chris-Hibbert added this pull request to the merge queue Aug 14, 2023
Merged via the queue into master with commit 7bfadd3 Aug 14, 2023
@Chris-Hibbert Chris-Hibbert deleted the 8123-dropOnly branch August 14, 2023 18:17
mhofman pushed a commit that referenced this pull request Aug 15, 2023
test: remove an inadvertent test.only addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code-style defensive correctness patterns; readability thru consistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants