Skip to content

WIP: CodeClimate Rubocop problem. #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RobertCram wants to merge 3 commits into
base: develop
Choose a base branch
from
+6 −10
Draft

WIP: CodeClimate Rubocop problem. #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a3885b
Solves CodeClimate Rubocop problem.
RobertCram Jun 16, 2022
d0c9291
Comment out rubocop-rake - it causes problems with CC.
RobertCram Jun 16, 2022
d94e6be
Removes rubocop-rake. It causes problems with CC.
RobertCram Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ engines:
enabled: true
rubocop:
enabled: true
channel: rubocop-0-75
channel: rubocop-1-22-2
ratings:
paths:
- Gemfile.lock
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ AllCops:
require:
- rubocop-rails
- rubocop-rspec
- rubocop-rake
# - rubocop-rake
- rubocop-performance

# ================================================================================
Expand Down
3 changes: 1 addition & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,9 @@ gem 'exception_handler', '~> 0.8.0', git: 'https://github.com/weedySeaDragon/exc
group :development, :test do
gem 'puma', '>= 5.6.4' # passenger is used on the production system

gem 'rubocop', '= 1.22.1', require: false
gem 'rubocop', '= 1.22.2', require: false
gem 'rubocop-rails', '= 2.13.2', require: false
gem 'rubocop-rspec', '= 2.9.0', require: false
gem 'rubocop-rake', require: false
gem 'rubocop-performance', '= 1.13.2', require: false

gem 'rspec-rails'
Expand Down
9 changes: 3 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ GEM
rb-inotify (0.10.1)
ffi (~> 1.0)
rb-readline (0.5.5)
regexp_parser (2.4.0)
regexp_parser (2.5.0)
responders (3.0.1)
actionpack (>= 5.0)
railties (>= 5.0)
Expand Down Expand Up @@ -466,7 +466,7 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.11.0)
rubocop (1.22.1)
rubocop (1.22.2)
parallel (~> 1.10)
parser (>= 3.0.0.0)
rainbow (>= 2.2.2, < 4.0)
Expand All @@ -484,8 +484,6 @@ GEM
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.7.0, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-rspec (2.9.0)
rubocop (~> 1.19)
ruby-progressbar (1.11.0)
Expand Down Expand Up @@ -684,10 +682,9 @@ DEPENDENCIES
rb-readline
routing-filter
rspec-rails
rubocop (= 1.22.1)
rubocop (= 1.22.2)
rubocop-performance (= 1.13.2)
rubocop-rails (= 2.13.2)
rubocop-rake
rubocop-rspec (= 2.9.0)
rubyzip (>= 1.2.1)
sanitize
Expand Down