Conversation
This reverts commit 2fdf9e1.
|
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a revert of a prior change that modified a German translation string. Specifically, it restores the original wording for a payment button label, ensuring consistency with the intended terminology. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Strict TypeScript Scan ResultsTotal: 3616 errors (baseline: 3616) | ✅ Pass Per-code breakdown (36 codes)
Last updated: 2026-03-12 13:56:42 UTC |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a change to a German translation key, changing the verb from 'kaufen' (to buy) back to 'zahlen' (to pay). My review points out that this re-introduces a linguistic inconsistency with another related translation key, which could affect user experience. I've recommended aligning these terms for better clarity.
| "payButton": "Kaufen", | ||
| "payButton.redirecting": "Umleiten…", | ||
| "payButton.with": "%{value} mit %{maskedData} kaufen", | ||
| "payButton.with": "%{value} mit %{maskedData} zahlen", |
There was a problem hiding this comment.
This change to 'zahlen' (to pay) introduces a linguistic inconsistency with the payButton label ('Kaufen' - to buy) on line 2. The main call to action is 'Buy', while the more specific action becomes 'Pay with...'. For a better user experience, these labels should be consistent, as they are in the English translations which use 'Pay' for both. Please consider aligning these terms, for example by changing payButton to 'Bezahlen' in a follow-up.
size-limit report 📦
|
|
@ScottiBR you haven't explained why we are reverting this. (Presumably so we can handle it with 2 different keys like mobile do? i.e depending on whether there is an amount or not? |
3 participants
Reverts #3863