fix: rename verify-jobs input parameter from 'results' to 'required'#3862
fix: rename verify-jobs input parameter from 'results' to 'required'#3862
Conversation
The verify-jobs action input parameter was misnamed in the workflow definitions. It should be 'required' to match the action.yml specification. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rectifies a significant oversight in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the results input parameter to required within the .github/actions/verify-jobs/action.yml file. The change is applied consistently, updating both the input definition and its usage within the action's run step. This appears to be a corrective change to fix a parameter mismatch, as described in the pull request. The changes are correct and I have no feedback.
Strict TypeScript Scan ResultsTotal: 3616 errors (baseline: 3616) | ✅ Pass Per-code breakdown (36 codes)
Last updated: 2026-03-12 12:47:32 UTC |
size-limit report 📦
|
- Intentionally break formatLocale test to verify verify-pr catches failures - Add empty required map check to verify-jobs action Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 participants
📋 Pull Request Checklist
📝 Summary
Fixes the verify-jobs action input parameter that was misnamed in the workflow definitions. The action.yml specifies 'required' as the input name, but it was being passed as 'results' from pr.yml.
This was causing the job verification to silently ignore test failures and always pass, allowing failing tests to slip through to merge queue.
Changes:
🧪 Tested scenarios
🔗 Related GitHub Issue / Internal Ticket number
Closes: