Skip to content

[payment] Code generation: update services and models#1427

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payment
Open

[payment] Code generation: update services and models#1427
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payment

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the payment service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 16, 2026 16:24
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new fields to the payment response data models, specifically ResponseAdditionalDataCard and ResponseAdditionalDataCommon. These additions enhance the information available in payment responses, supporting new functionalities like alternate card IDs for specific regions and clearer indications of network processing modes. The changes are a result of automated code generation, ensuring the payment service models remain up-to-date with the latest API specifications.

Highlights

  • New Field: cardAltID: The ResponseAdditionalDataCard model now includes a cardAltID property, representing an alternate ID mapped to the Card PAN, specifically for Ecommerce Card Payments in India.
  • New Field: networkProcessingMode: The ResponseAdditionalDataCommon model has been extended with a networkProcessingMode property, indicating the processing flow (e.g., 'sale' or 'auth').

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Adyen/Payment/Models/ResponseAdditionalDataCard.cs
    • Added cardAltID property to the ResponseAdditionalDataCard class.
    • Updated the constructor to accept cardAltID as an optional parameter.
    • Integrated cardAltID into the ToString() method for string representation.
    • Modified the JSON Read and Write methods to handle serialization and deserialization of cardAltID.
  • Adyen/Payment/Models/ResponseAdditionalDataCommon.cs
    • Added networkProcessingMode property to the ResponseAdditionalDataCommon class.
    • Updated the constructor to accept networkProcessingMode as an optional parameter.
    • Integrated networkProcessingMode into the ToString() method for string representation.
    • Modified the JSON Read and Write methods to handle serialization and deserialization of networkProcessingMode.
Activity
  • The pull request was created by AdyenAutomationBot, indicating automated code generation.
  • The changes reflect updates from adyen-openapi commits, ensuring synchronization with API specifications.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the cardAltID and networkProcessingMode properties to the payment models, which appears to be auto-generated from an OpenAPI specification. The changes are consistent with the existing code structure. I've added a couple of suggestions to improve the code style in the JSON serialization methods, which could potentially be applied to the code generator for wider impact.

Comment on lines +534 to +537
if (responseAdditionalDataCard._CardAltIDOption.IsSet)
if (responseAdditionalDataCard.CardAltID != null)
writer.WriteString("cardAltID", responseAdditionalDataCard.CardAltID);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The nested if statements can be combined into a single condition for better readability and conciseness. Using braces also improves code clarity and prevents potential issues if more statements are added later. Since this is generated code, this might be an improvement to apply to the code generator template.

            if (responseAdditionalDataCard._CardAltIDOption.IsSet && responseAdditionalDataCard.CardAltID != null)
            {
                writer.WriteString("cardAltID", responseAdditionalDataCard.CardAltID);
            }

Comment on lines +2093 to +2096
if (responseAdditionalDataCommon._NetworkProcessingModeOption.IsSet)
if (responseAdditionalDataCommon.NetworkProcessingMode != null)
writer.WriteString("networkProcessingMode", responseAdditionalDataCommon.NetworkProcessingMode);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The nested if statements can be combined into a single condition for better readability and conciseness. Using braces also improves code clarity and prevents potential issues if more statements are added later. Since this is generated code, this might be an improvement to apply to the code generator template.

            if (responseAdditionalDataCommon._NetworkProcessingModeOption.IsSet && responseAdditionalDataCommon.NetworkProcessingMode != null)
            {
                writer.WriteString("networkProcessingMode", responseAdditionalDataCommon.NetworkProcessingMode);
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant