Skip to content

Fix quantized_embedding_norm undefined when normalize=False #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stes merged 2 commits into from
May 5, 2025
Merged

Fix quantized_embedding_norm undefined when normalize=False #249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e0e65
Fix quantized_embedding_norm undefined when normalize=False
CeliaBenquet Apr 25, 2025
d1c82b1
Add test
CeliaBenquet Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cebra/integrations/sklearn/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ def align_embeddings(
quantized_sample / np.linalg.norm(quantized_sample, axis=0)
for quantized_sample in quantized_embedding
]
quantized_embeddings.append(quantized_embedding_norm)
else:
quantized_embeddings.append(quantized_embedding)

quantized_embeddings.append(quantized_embedding_norm)
return quantized_embeddings