Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUI: Add import capability to component anatomy definitions #233

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

bheston
Copy link
Member

@bheston bheston commented Oct 17, 2024

Pull Request

Description

Allows extracting common definitions shared across multiple components.

Initial example is adding success/error validation across all inputs.

  • Can define those styles in one definition file
  • Import that file in all input components

Reviewer Notes

The deepmerge package seemed to be the most efficient way to merge the json docs, but open to suggestions.

Test Plan

Tested in AUI pipeline.

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

@bheston bheston merged commit bb8d1a2 into main Oct 18, 2024
3 checks passed
@bheston bheston deleted the users/bheston/aui-anatomy-import branch October 18, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants