-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S18-Lions-Yun Liu #98
base: master
Are you sure you want to change the base?
Conversation
… text, and content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal Portfolio Site
What We're Looking For
Feature | Feedback |
---|---|
Baseline | |
Appropriate Git Usage | ✅ |
Answered comprehension questions | ✅ |
Page fully loads | ✅ |
No broken links (regular or images) | 😞 |
Includes at least 3 pages and styling | ✅ |
HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article , etc. |
✅ |
All images include alternate text | 😞 |
CSS | |
Using class and ID names in style declarations | ✅ |
Style declarations are DRY | ✅ |
Uses Flexbox and/or Grid | ✅ |
Overall | ✅ |
|
||
<header> | ||
<nav> | ||
<div id="logo"><a href="/pages/index.html" rel="about" class="logo">Home</a></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful with your file paths! The /pages/index.html
path does not actually work because it is an incorrect absolute path. Starting a path with a slash (/) will start the file search at the root directory of your entire file system (not your project).
To correct this, we can use a relative path instead. This will provide directions to the target file based on the current file's location.
In code this looks like: ./pages/index.html
. The dot at the beginning signals to start searching in the current directory.
Here is a great resource on absolute vs relative paths: https://www.geeksforgeeks.org/absolute-relative-pathnames-unix/
This applies to links to the CSS files and for images as well.
<p>© Copyright: 2022, Yun Liu All Rights Reserved</p> | ||
<ul> | ||
<li> | ||
<img src="https://img.icons8.com/color/48/null/gmail--v2.png" alt=" "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alt text should not be an empty string. People who are blind or have low vision depend on screen readers to tell them what is on a webpage. Screen readers use the alt text to explain to the user what the image is. This tricks the HTML validator into not throwing an error, but it is still not good for the user who will not understand what these images are.
<p>A Python program that replaces the spreadsheet method and allows users to keep track or movies watched and enjoyed.</p> | ||
<p>Friends are able to share their favorite lists and watched lists. Friends can edit, delete, and add to watch list and favorite list.</p> | ||
</article> | ||
<img src="/imgs/viewing_party.png" alt="Viewing Party"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good for the alt text to be more descriptive. The picture itself is not of a party of people viewing something. It is a picture of VS Code displaying the code you wrote for this.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions