-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cheetahs-Wanjun Lan #97
base: master
Are you sure you want to change the base?
Changes from all commits
78b128a
237f23d
f80bb07
e3c024b
58e9b61
a7b576f
2181353
32dd774
6fc2a3d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"liveServer.settings.port": 5502 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,100 @@ | |
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
<title>About Me</title> | ||
<link href="styles/style.css" rel=Stylesheet> | ||
</head> | ||
<body> | ||
<body> | ||
<header class="about-header"> | ||
<nav class="ss-bg"> | ||
<ul id="menu" class="about-menu"> | ||
<li><a href="http://127.0.0.1:5502/pages/index.html"><h3>Home</h3></a></li> | ||
<li><a href="http://127.0.0.1:5502/pages/about.html"><h3>About</h3></a></li> | ||
<li><img id="About-me-logo" alt="logo" src="../assets/ABOUT+ME+LOGO.png"></li> | ||
<li><a href="http://127.0.0.1:5502/pages/portfolio.html"><h3>Portfolio</h3></a></li> | ||
<li><a href="https://www.linkedin.com/in/wanjun-lan/"><h3>Contact</h3></a></li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<div id="div-grid"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems there are a lot of divs being used on your pages. Instead, please consider using semantic tags like |
||
<article id="article-grid"> | ||
<div class="article-grid-items"> | ||
<h2>Hi. I'm Cool. See Below.</h2> | ||
</div> | ||
<div class="article-grid-items"> | ||
<p><em>Software Developer Student, Biotech Researcher, Audiophile, Photographer, Dreamer</em></p> | ||
</div> | ||
</article> | ||
<main id="main-grid"> | ||
<div class="main-wrapper"> | ||
<p> | ||
Wanjun Lan is lover of many things including, but not limited to: spicy Thai, dry red wines, | ||
Imperial stouts, IPAs, whiskey tastings, outdoor adventures, backpacking the wilderness, | ||
international travel, Films: All Wes Anderson Films, Eternal Sunshine, Stranger Than Fiction, | ||
Wristcutters: A Love Story, Books: American Gods, The Wind Up Bird Chronicles, The Diving Bell | ||
and the Butterfly, The Fault In Our Stars, The Motorcycle Diaries, iced Americanos, good music, | ||
better conversations. | ||
</p> | ||
</div> | ||
<div class="about-main-container"> | ||
<div> | ||
<img class="me-photo" alt="fuji" src="../assets/Fuji.JPG"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good for alt text to be more descriptive. Alt text is used by screen readers for people who are blind to explain to them what the picture is. Just saying "Fuji" is not enough to help someone who is blind understand what is in the picture. |
||
</div> | ||
<div> | ||
<img class="me-photo" alt="disney" src="../assets/Disney.JPG"> | ||
</div> | ||
<div> | ||
<img class="me-photo" alt="karuizawa" src="../assets/Karuizawa.JPG"> | ||
</div> | ||
<div> | ||
<img class="me-photo" alt="kawagoe" src="../assets/Kawagoe.JPG"> | ||
</div> | ||
<div> | ||
<img class="me-photo" alt="sakura" src="../assets/Sakura.JPG"> | ||
</div> | ||
<div> | ||
<img class="me-photo" alt="italy" src="../assets/Italy.JPG"> | ||
</div> | ||
<div> | ||
<img class="me-photo" alt="christmas" src="../assets/Christmas.JPG"> | ||
</div> | ||
</div> | ||
|
||
</main> | ||
|
||
<aside id="aside-grid"> | ||
<div class="about-aside-wrapper"> | ||
<div> | ||
<h3 class="aside-header">Skills</h3> | ||
<p><b>Programming</b>: Flask, PostgreSQL, HTML, CSS, Python, Object-oriented design, Test-driven development, Web Crawling </p> | ||
<p><b>Biotech</b>: Cell Culture, Gene Cloning, RT-PCR, SDS-PAGE, Western Blot, Confocal laser Scanning Microscopy(CLSM) </p> | ||
</div> | ||
<div> | ||
<h3 class="aside-header">Education</h3> | ||
<p class="university">East China University of Science and Technology</p> | ||
<p class="degree">Biotechnology and Engineering, Ph.D</p> | ||
<p class="university">University of Tokyo</p> | ||
<p class="degree">Bioengineering Joint-training, Ph.D</p> | ||
</div> | ||
<div> | ||
<h3 class="aside-header">Publications</h3> | ||
<ol> | ||
<li><a href="https://pubmed.ncbi.nlm.nih.gov/26105688/">Publication-1 Second Author</a></li> | ||
<li><a href="https://pubmed.ncbi.nlm.nih.gov/24891524/">Publication-2 First Author</a></li> | ||
<li><a href="https://pubs.rsc.org/en/content/articlelanding/2012/ay/c1ay05549f">Publication-3 First Author</a></li> | ||
</ol> | ||
</div> | ||
</div> | ||
</aside> | ||
</div> | ||
|
||
<footer> | ||
<p class="copyright">& Copyright 2022 Wanjun Lan</p> | ||
</footer> | ||
|
||
|
||
|
||
|
||
</body> | ||
|
||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,46 @@ | |
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
<title>Wanjun's homepage</title> | ||
<link href="styles/style.css" rel=Stylesheet> | ||
</head> | ||
<body> | ||
|
||
<header> | ||
<div id="home-header"><h1> WANJUN LAN </h1></div> | ||
<div class="image"></div> | ||
<nav> | ||
<ul class="home-menu"> | ||
<li><a href="http://127.0.0.1:5502/pages/index.html"><b>Home</b></a></li> | ||
<li><a href="http://127.0.0.1:5502/pages/about.html"><b>About</b></a></li> | ||
<li><a href="http://127.0.0.1:5502/pages/portfolio.html"><b>Portfolio</b></a></li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<div> | ||
<div> | ||
<div class="index-main-container"> | ||
<div> | ||
<a href="/about.html"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This link also does not work because it is an absolute path instead of a relative path. Please see the comment above about absolute vs relative. |
||
<img id="Wanjun_photo" alt='wanjun profile image' src="../assets/WanjunLan_profile_photo.png"> | ||
</a> | ||
</div> | ||
<div class="homepage-wrapper"> | ||
<p>Hi, I'm Wanjun.</p> | ||
<p>I'm currently a software engineer student at Ada Developers Academy. I used to be a scientific researcher in biotech. Welcome to my homepage!</p> | ||
<p>Intrigued by travelling, photography, music, logic thinking, programming, fabulous food and even better conversations.</p> | ||
<p>Seeking to be inspired, to envision the unlikely, to work hard for things that are worth it, and to be surrounded by those who bring out the best in me.</p> | ||
<p>Find me on | ||
<a href="https://www.facebook.com/profile.php?id=100087884298513"><img class="logo" alt='Facebook' src='../assets/Facebook.png'></a> | ||
<a href="https://www.instagram.com/allie99883/"><img class="logo" alt='Instagram' src='../assets/Instagram.png'></a> | ||
<a href="https://twitter.com/WanjunLan"><img class="logo" alt='Twitter' src='../assets/Twitter.png'></a> | ||
<a href="https://www.linkedin.com/in/wanjun-lan/"><img class="logo" alt='LinkedIn' src='../assets/LinkedIn.png'></a> | ||
</p> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
<footer> | ||
<p class="copyright">& Copyright 2022 Wanjun Lan</p> | ||
</footer> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links do not work. We should use relative paths to reference other pages, similar to what you have on line 16 to get to the assets. Here is a great resource on absolute vs relative paths: https://www.geeksforgeeks.org/absolute-relative-pathnames-unix/