Personal Portfolio - Jennifer N. #119
Conversation
| @@ -1,12 +1,46 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Prefer not to nest the images folder within the pages folder.
| <header> | ||
| <h1 class="page-title"> About Jennifer </h1> | ||
| <nav class="nav-menu"> | ||
| <div> |
There was a problem hiding this comment.
We can do without the divs here. Since the divs just wrap the as directly, making the as the direct children of the nav would have the same effect (since the nav has grid styling).
Alternatively, since we should aim for making our markup look good even if the styles are absent, we might logically group the as under a list. It's not necessary when the styles are applied, but can be handy from a logical standpoint.
| <h2>Glowing Reviews</h2> | ||
| <div> | ||
| <p class = "stars"> ⭐⭐⭐⭐⭐ </p> | ||
| <blockquote>"Amazing to work with! 5 stars."</blockquote> |
| <a href="/pages/index.html"> Home </a> | ||
| </div> | ||
| <div> | ||
| <a href="/pages/portfolio.html"> Portfolio </a> |
There was a problem hiding this comment.
Be careful using absolute paths for links/resources. They can simplify refering to files within your site, but they make the assumption that this page will be hosted at the root location of website, which isn't always true for all deployment hosts.
|
|
||
| <!-- portfolio --> | ||
| <main class="portfolio"> | ||
| <div id="project_1"> |
There was a problem hiding this comment.
Consider using a section for each of these, since they have a heading and additional content.
| @@ -0,0 +1,69 @@ | |||
| # This file must be used with "source bin/activate" *from bash* | |||
There was a problem hiding this comment.
No need to create a venv since this isn't a python project.
| <main class="hero-page-content"> | ||
| <h2>Hi, I'm Jennifer</h2> | ||
| <p> and I write <code>#code</code> in:</p> | ||
| <ul> |
There was a problem hiding this comment.
I might style this to remove the bullets and left margin. That would logically keep these a lit, but visually center them along with the rest of the content.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions