Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carina Bauman S18 Lions #114

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Carina Bauman S18 Lions #114

wants to merge 11 commits into from

Conversation

checarina
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? To my surprise, I only encountered one error running my pages through the validator. OTOH, I could not figure out why I was getting the error (supposedly a mismatched

tag, but I swear it was in the right place).
Why is it important to consider and use semantic HTML? Semantic HTML helps you organize your page, helps others understand your code, and helps improve accessibility.
How did you decide to structure your CSS? Largely arranged selectors by alphabetical order though that got messed up a bit when I renamed some rules.
What was the most challenging piece of this assignment? Deploying to GitHub Pages for some reason!!!!
Describe one area that you gained more clarity on when completing this assignment HTML & CSS have changed a lot since I was a young web developer employing tables and frames to create elaborate page layouts that would break immediately upon encountering a different browser or screen resolution. It was an interesting challenge to let my HTML stay 'ugly' and rely on CSS to do the heavy lifting of arranging elements on the page. But with some practice, it's a much more powerful, flexible, and transparent way of building pages!
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? https://checarina.github.io/index.html

Copy link

@nancy-harris nancy-harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage
Answered comprehension questions
Page fully loads
No broken links (regular or images)
Includes at least 3 pages and styling
HTML
Uses the high-level tags for organization: header, footer, main
Appropriately using semantic tags: section, article, etc.
All images include alternate text
CSS
Using class and ID names in style declarations
Style declarations are DRY
Uses Grid or Flexbox
Overall 💯

}

.about {
display: grid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, grid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants