Lions-devin-personal-portfolio #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | Almost! |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
✅ |
| All images include alternate text | 🤷♀️ |
| CSS | |
| Using class and ID names in style declarations | 😞 Uses class, but not ID |
| Style declarations are DRY | ✅ |
| Uses Flexbox and/or Grid | ✅ |
| Overall | ✅ |
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| <link href="/stylesheets/style.css" rel="stylesheet"> |
There was a problem hiding this comment.
Careful with your file paths! The /stylesheets/style.css path does not actually work because it is an incorrect absolute path. Starting a path with a slash (/) will start the file search at the root directory of your entire file system (not your project).
To correct this, we can use a relative path instead. This will provide directions to the target file based on the current file's location.
In code this looks like: ./stylesheets/style.css. The dot at the beginning signals to start searching in the current directory.
Here is a great resource on absolute vs relative paths: https://www.geeksforgeeks.org/absolute-relative-pathnames-unix/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
Why is it important to consider and use semantic HTML? |
It helps make your file more clear and easy to understand
How did you decide to structure your CSS? |
I organized it by the order that elements show up in the html files.
What was the most challenging piece of this assignment? |
I wasn't able to get my css to interact with my html. I am not getting any errors and all files are valid.
Describe one area that you gained more clarity on when completing this assignment |
I gained some more clarity on semantic html
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |