Lions - Jessica A #104
Open
Lions - Jessica A #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | 😞 |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
Mostly. The index.html page does not have any |
Appropriately using semantic tags: section, article, etc. |
Mostly. The index.html page only uses div |
| All images include alternate text | ✅ |
| CSS | |
| Using class and ID names in style declarations | 😞 Only has class, does not use ID |
| Style declarations are DRY | ✅ |
| Uses Flexbox and/or Grid | ✅ |
| Overall | ✅ |
| <link href="style.css" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <header> |
There was a problem hiding this comment.
This header tag does not have a corresponding closing tag.
| <div class="grid-container"> | ||
| <div class="item1"><h1>Jessica Edith Ambriz-Madrigal </h1></div> | ||
| <div class="item2"> | ||
| <div><p><a href="file:///Users/jessicaambriz-madrigal/Developer/projects/personal-portfolio-site/pages/index.html"> Home </a></p></div> |
There was a problem hiding this comment.
Be careful with your links! This is looking for a specific file on your computer. These links do not work if other people are trying to open your webpage. Instead, you should use relative paths.
Here is a great resource on absolute vs relative paths: https://www.geeksforgeeks.org/absolute-relative-pathnames-unix/
This applies to image URLs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
Did you have to resolve any issues when running the HTML Validator? If so, what were they? |
Yes, I had multiple happen at different times and tried my best to have an error-free HTML. Usually, I would forget a > or < or add a type of heading that is not allowed in the footer.
:------------- | :-------------
Why is it important to consider and use semantic HTML? |
So the website can look clean and the user can understand and want to look at the information at hand.
:------------- | :-------------
How did you decide to structure your CSS? |
I drew out first what kind of design I was looking for.
:------------- | :-------------
What was the most challenging piece of this assignment? |
I think the way CSS was not always doing what I wanted it to do, or getting the grid to be ending on the sides of the page.
:------------- | :-------------
Describe one area that you gained more clarity on when completing this assignment |
I think provided more insight into how disconnected the background and the content is. Realizing how actually more intricate web development is.
:------------- | :-------------