fix: attempts at fixing init and consent #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/eventPage.js
Outdated
| */ | ||
|
|
||
| function init() { | ||
| chrome.storage.local.get("enabled", async function(obj) => { |
Check notice
Code scanning / CodeQL
Syntax error
|
@Morpheus0x Would really appreciate it if you could take a look at (and maybe test) this. The bug has been very elusive for me, not sure if this actually fixes it, but it makes more sense in my head. |
ErikBjare
force-pushed
the
dev/fix-consent-and-init
branch
from
342a90c to
38c7462
Compare
|
I've done some minor testing now. Deciding to make a release out of this and see if that fixes things. |
powellnorma
pushed a commit
to powellnorma/aw-watcher-web
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix:
Haven't precluded the possibility that #109 is a possible fix.
I've just written code so far. I've done 0 testing. Testers and coauthors appreciated.