Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

asukaminato0721
Copy link
Contributor

fix part of #2

Copy link
Member

@0xbrayo 0xbrayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikBjare
Copy link
Member

I'm not sure if this is quite right. Since we ship binaries with most of these libraries already included, we actually don't depend on many/most of them being installed.

I also think many of these are transient dependencies, thus shouldn't be explicitly listed in the PKGBUILD.

@0xbrayo
Copy link
Member

0xbrayo commented Sep 5, 2024

I guess I could strip the new dependencies, just keep the version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants