feat!: Implement refactored ScrollIntoView action across desktop platforms
#594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
approved these changes
Jul 14, 2025
DataTriny
requested changes
Jul 15, 2025
platforms/macos/src/node.rs
Outdated
| @@ -961,6 +963,37 @@ declare_class!( | |||
| .flatten() | |||
| } | |||
|
|
|||
| // We discovered through epxerimentation that when mixing the newer | |||
There was a problem hiding this comment.
Suggested change
| // We discovered through epxerimentation that when mixing the newer | |
| // We discovered through experimentation that when mixing the newer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
ScrollTargetaction data wasn't a good fit for what any platform actually supported. So I replaced it with a newScrollHintwhich is a copy of Chromium'sScrollTypeenum, which in turn is a copy of AT-SPI'sScrollType.The Windows implementation is known to work with Narrator, and the macOS implementation is known to work with VoiceOver. I don't know if there's any way to get Orca to call the
ScrollTomethod outside of web content. I know that NVDA doesn't callScrollIntoViewoutside of web content. All of this can be tested using my virtual-scroll-a11y branch of xilem. That's actually still using the scrolling-wip branch of AccessKit, but it's the same code. I'll delete that branch after this PR is merged and the Xilem branch is rebased.