Skip to content

Increase colour_transform coverage #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antond-weta merged 1 commit into from
Jan 28, 2026
Merged

Increase colour_transform coverage #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rawtoaces_util/cache_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ template <typename... Ts>
std::ostream &operator<<( std::ostream &os, const std::tuple<Ts...> &tuple )
{
return println_tuple_impl( os, tuple, std::index_sequence_for<Ts...>{} );
}
} // LCOV_EXCL_LINE - bug in coverage tool

namespace cache
{
Expand Down
10 changes: 5 additions & 5 deletions src/rawtoaces_util/transform_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ std::ostream &
operator<<( std::ostream &os, const rta::core::Metadata &data [[maybe_unused]] )
{
return os << std::string( "<Metadata>" );
Copy link
Copy Markdown
Contributor

@antond-weta antond-weta Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return os << std::string( "<Metadata>" );
os << std::string( "<Metadata>" );
return os;

would this help?

Copy link
Copy Markdown
Contributor Author

@soswow soswow Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=(

Image

}
} // LCOV_EXCL_LINE - bug in coverage tool

bool operator==(
const rta::core::Metadata &data1, const rta::core::Metadata &data2 )
Expand Down Expand Up @@ -48,31 +48,31 @@ get_WB_from_illuminant_cache()
static cache::Cache<CameraAndIlluminantDescriptor, WBFromIlluminantData>
WB_from_illuminant_cache( "WB from illuminant" );
return WB_from_illuminant_cache;
}
} // LCOV_EXCL_LINE - bug in coverage tool

cache::Cache<CameraAndWBDescriptor, IlluminantAndWBData> &
get_illuminant_from_WB_cache()
{
static cache::Cache<CameraAndWBDescriptor, IlluminantAndWBData>
illuminant_from_WB_cache( "illuminant from WB" );
return illuminant_from_WB_cache;
}
} // LCOV_EXCL_LINE - bug in coverage tool

cache::Cache<CameraAndIlluminantDescriptor, MatrixData> &
get_matrix_from_illuminant_cache()
{
static cache::Cache<CameraAndIlluminantDescriptor, MatrixData>
matrix_from_illuminant_cache( "matrix from illuminant" );
return matrix_from_illuminant_cache;
}
} // LCOV_EXCL_LINE - bug in coverage tool

cache::Cache<MetadataDescriptor, MatrixData> &
get_matrix_from_dng_metadata_cache()
{
static cache::Cache<MetadataDescriptor, MatrixData>
matrix_from_dng_metadata_cache( "matrix from DNG metadata" );
return matrix_from_dng_metadata_cache;
}
} // LCOV_EXCL_LINE - bug in coverage tool

} // namespace cache
} // namespace rta
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ endif()
add_executable (
Test_usage_example_core
usage_example_core.cpp
test_utils.cpp
)

target_link_libraries(
Expand Down
Loading