-
Notifications
You must be signed in to change notification settings - Fork 314
Run tests on wheels #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Run tests on wheels #1977
Conversation
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
ac4cb5f to
39742e7
Compare
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
+ Coverage 85.13% 85.15% +0.01%
==========================================
Files 181 181
Lines 12783 12783
Branches 1206 1206
==========================================
+ Hits 10883 10885 +2
+ Misses 1717 1715 -2
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
… distro (mingw) Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
…ist resolution, made wheels no longer depend on smoketest Signed-off-by: Eric Reinecke <[email protected]>
2293046 to
f323137
Compare
Signed-off-by: Eric Reinecke <[email protected]>
…ing in mingw build Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
ec030a9 to
742dc6c
Compare
Signed-off-by: Eric Reinecke <[email protected]>
…act is available for install and the repo is subsequently used for testing Signed-off-by: Eric Reinecke <[email protected]>
|
I'm ready for feedback on this - just the one open questions about whether or not we really need the smoketests or if I should move the coverage reports to the tests we run on the equivalent wheel. |
This change re-shuffles the CI so that:
Ideally this would take the suggestion from @JeanChristopheMorinPerso and run againstsdist- that change hasn't been made.Update: after investigation, cibuildwheel isn't really meant to happen from sdist sources. I did a pass to make our build and test only phase run off it though - since those platforms would be running off sdist in the wild.
Additionally, if we could capture coverage from one of the cibuildwheel runs, we could probably eliminate the smoke test phase.
Consider dropping the smoke test and just harvest coverage from testing the wheelsFixes #1027
This supersedes #1961 - the changes have been added to this PR