Graph Editor : Add snapshot capability #2430
Open
+134
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add in save dialog and help. - Ad in CTRL-I vs CTRL-SHIFT-I to capture editor or whole window.
kwokcb
commented
May 30, 2025
There was a problem hiding this comment.
@lfl-eholthouser : I've added this as a new snapshot utility. Have a look when you have time and let me know what you think. Thanks.
| @@ -326,6 +332,14 @@ class Graph | |||
|
|
|||
| // Options | |||
| bool _saveNodePositions; | |||
|
|
|||
| // Panel information | |||
There was a problem hiding this comment.
Make class members to track panel placement / size changes.
Also pull out constant 15 indent to avoid hard-coded numbers.
| @@ -4031,6 +4072,65 @@ void Graph::handleRenderViewInputs() | |||
| } | |||
| } | |||
|
|
|||
| mx::ImagePtr Graph::performSnapshot(bool captureWindow) const | |||
There was a problem hiding this comment.
Snapshot function : takes into account the current splitter layout and extra formatting (indentation).
| static float leftPaneWidth = 375.0f; | ||
| static float rightPaneWidth = 750.0f; | ||
| splitter(true, 4.0f, &leftPaneWidth, &rightPaneWidth, 20.0f, 20.0f); | ||
| splitter(true, 4.0f, &_leftPaneWidth, &_rightPaneWidth, 20.0f, 20.0f); |
There was a problem hiding this comment.
Remove some hard-coded statics and make class members for reuse during snapshot.
| @@ -3180,6 +3185,40 @@ void Graph::saveGraphToFile() | |||
| _fileDialogSave.open(); | |||
| } | |||
|
|
|||
| void Graph::showSnapshotDialog() | |||
There was a problem hiding this comment.
Some file dialog infrastructure. Save uses the current captured image.
kwokcb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes issue #2429
Add in "snapshot" capability for node editor panel.
Interface Changes
New Keys
CTRL-I: capture the editor panelCTRL-SHIFT-I: capture the entire windowHelp Dialog Update
Each option will bring up file dialog to allow user to input file name to save. Defaults to PNG extension.
Examples: