feat(core): quality audit — hardened serialization, docs, and test coverage#11
Merged
Merged
Conversation
…verage - Improved SerializationError with SaveFailed/LoadFailed variants carrying path context for actionable error messages - Added compact serialization roundtrip test (previously untested) - Added error path test for loading nonexistent model files - Added SerializationError::Display test for all variants - Documented phase1_batched norm sharing behavior in two_phase.rs - Added doc comments on init_op, init_layer, MultiHeadAttentionConfig::init, FeedForwardConfig::init - Fixed ROADMAP incorrectly describing FeedForward as "SwiGLU-style MLP" - Added CHANGELOG.md with full release history - Updated test counts across README, AGENTS.md, ROADMAP.md, CLAUDE.md (87 tests) - All 87 tests pass, clippy clean, fmt clean https://claude.ai/code/session_01HiZGPH4ZywpE1Ao4frWnxr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path context for actionable error messages
FeedForwardConfig::init
https://claude.ai/code/session_01HiZGPH4ZywpE1Ao4frWnxr