Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff pyupgrade #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ruff pyupgrade #942

wants to merge 2 commits into from

Conversation

boxydog
Copy link

@boxydog boxydog commented Jan 28, 2024

These are all automated fixes from ruff "PY" (pyupgrade).

Includes more aggressive fixes

@boxydog
Copy link
Author

boxydog commented Jan 28, 2024

@evgenyfadeev
Copy link
Member

Thanks! This first pass I'll review manually, so it may take some time (perhaps a week) to merge.

@boxydog
Copy link
Author

boxydog commented Jan 28, 2024

Sounds good, thanks for letting me know.

Just FYI, I think almost everything is two changes:

  • string formatting from "%s" % foo to f"{foo}"
  • super(Class, this) to super()

IMO, the useful part of this change is allowing pyupgrade to run on every PR, so it will keep python usage a bit more standard, and a bit more modern. That is my overall pitch for ruff: it will keep the codebase more standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants