FIX: Fix CAPPI to account for atmospheric refraction#1830
Merged
zssherman merged 5 commits intoARM-DOE:mainfrom Mar 5, 2026
Merged
FIX: Fix CAPPI to account for atmospheric refraction#1830zssherman merged 5 commits intoARM-DOE:mainfrom
zssherman merged 5 commits intoARM-DOE:mainfrom
Conversation
Contributor
Author
|
Kindly confirm @scollis, @tsbiscaro |
zssherman
approved these changes
Feb 9, 2026
Collaborator
|
@RBhupi Whenever you have time, if you can give a review of this as well |
Contributor
Author
|
I’m seeing a rotation issue when creating a CAPPI. Using the sample |
zssherman
reviewed
Feb 23, 2026
Collaborator
|
Nice to reconnect with you @syedhamidali ! Adding height tolerance is a good decision. I could not understand why the rotation issues caused only in Nexrad file. Wht fixed it? |
RBhupi
approved these changes
Mar 2, 2026
zssherman
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated CAPPI to honor radar geometry and the standard refractivity model. The routine now pulls gate heights from radar.gate_z (which already includes the 4/3 Earth-radius/curvature effect), aligns them to a common azimuth grid per sweep, and selects the nearest gates via that geometry. Field data interpolation now stays aligned with these refractivity-aware heights after Nyquist filtering, replacing the previous flat-Earth R*sin(elevation) approximation.