WHL: upgrade cibw, migrate static configuration to pyproject.toml, enable cp313 wheels - #1810
Merged
Merged
Conversation
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
3 times, most recently
from
November 22, 2025 18:04
7bd1f24 to
7c77987
Compare
neutrinoceros
commented
Nov 22, 2025
neutrinoceros
commented
Nov 22, 2025
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
from
November 22, 2025 18:13
7c77987 to
526fbb2
Compare
neutrinoceros
commented
Nov 22, 2025
| skip = [ | ||
| "cp38-*", | ||
| "cp39-*", | ||
| "cp314t-*", |
Contributor
Author
There was a problem hiding this comment.
given that both 3.13 and 3.14 wheels were missing I assumed that free-threading wasn't supported yet. Note that cibuildwheel 3.2 and newer just enable it by default for 3.14, not 3.13 (because it was marked as experimental for that version), so, to be conservative, and because it's potentially much more work to add, I just disabled this one explicitly.
neutrinoceros
commented
Nov 22, 2025
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
2 times, most recently
from
November 22, 2025 18:54
1b11abb to
7357302
Compare
neutrinoceros
changed the title
Collaborator
|
Hi @neutrinoceros, thank you for the PR! A few of us are out for the holiday, but can give this a review soon! We greatly appreciate this PR to update the wheels etc! |
Contributor
Author
|
Absolutely no rush on my end, enjoy your holiday ! |
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
from
November 22, 2025 19:56
7357302 to
4e84fb0
Compare
neutrinoceros
changed the title
neutrinoceros
commented
Nov 22, 2025
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
from
November 22, 2025 20:26
4e84fb0 to
ee4eb81
Compare
neutrinoceros
marked this pull request as ready for review
November 22, 2025 21:50
4 tasks
neutrinoceros
force-pushed
the
whl/cp313-cp314
branch
from
December 3, 2025 17:16
ee4eb81 to
8fdf08b
Compare
Contributor
Author
|
rebased to include changes from #1813 |
zssherman
approved these changes
Dec 3, 2025
zssherman
left a comment
zssherman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks @neutrinoceros !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the latest version didn't have wheels for Python 3.13 or 3.14, so I did a bit of housecleaning to enable them.
The reason I'm also making an attempt at enabling musllinux wheels is that the documented reason for disabling them is outdated: numpy has been supporting this target for some time now.
Out of scope here, but note that Cython>=3.1 is now able to generate Limited API-compliant C code, which means it should be relatively easy to both improve the future-portability of your wheels and reduce the overall number of wheels you need to produce for each release. I'd be happy to contribute this too if desired.