Skip to content

FWF-4603: [Bugfix] Removed default variables applicationId and FormName from filter list api #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

auslin-aot
Copy link
Contributor

@auslin-aot auslin-aot commented May 8, 2025

User description

Issue Tracking

JIRA:
Issue Type: BUG/ FEATURE
https://aottech.atlassian.net/browse/FWF-4603

Changes

Removed default variables applicationId and FormName appended to the Filter list api

Screenshots

image
image

Checklist

  • Updated changelog
  • Added meaningful title for pull request

PR Type

Bug fix


Description

  • Clear default applicationId and formName filters

  • Set "All Tasks" variables to empty list

  • Remove default_variables definition and merging logic


Changes walkthrough 📝

Relevant files
Bug fix
filter.py
Remove default filter variables logic                                       

forms-flow-api/src/formsflow_api/services/filter.py

  • Set "All Tasks" filter variables to empty list
  • Delete default_variables list and its usage
  • Stop auto-appending default filter variables
  • +1/-12   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @auslin-aot auslin-aot requested review from a team as code owners May 8, 2025 07:16
    Copy link

    github-actions bot commented May 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consumer expectations

    Removing default applicationId and formName variables may break clients or UIs expecting these filters; confirm front-end compatibility and update any documentation or integration tests accordingly.

    variables=[],
    Test coverage

    There are no tests verifying that get_user_filters now returns an empty variables list in all scenarios; consider adding unit tests to cover both the new default case and existing filter merging logic.

    filter_item["variables"] = filter_item["variables"] or []

    Copy link

    sonarqubecloud bot commented May 8, 2025

    Copy link

    github-actions bot commented May 8, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants