Skip to content

Conversation

@navaneeth0041
Copy link
Contributor

Description

This PR adds monument checkout functionality to complete the visit lifecycle. Currently, users can check in to monuments but have no way to complete or end their visit, leaving user data in an incomplete state. This implementation adds a "Check Out" button that replaces the "Check In" button when a user is already checked in, with a confirmation dialog that matches the existing design pattern.

Fixes #274

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Checking in to a monument and verifying the button changes to "Check Out"
  • Confirming the checkout dialog appears with the correct design and text
  • Verifying successful checkout shows the appropriate snackbar message
  • Confirming the button reverts to "Check In" after checkout
2025-03-06.20-48-18.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@navaneeth0041 navaneeth0041 requested a review from jddeep as a code owner March 6, 2025 15:29
@mdmohsin7
Copy link
Member

I initially added the check in feature only to add a post to the user's profile so that they don't fake their visits. I'm not sure if we should have a check out state in this case. We could maybe overhaul the check-in thing. Do you know of any apps that make use of the check-in check-out functionality? Curious to see

@navaneeth0041
Copy link
Contributor Author

so, instead of this should I make a log or a dedicated section to show monuments which have checked-in?

@navaneeth0041
Copy link
Contributor Author

and also what if someone does check-in and later thinks about removing it?

@mdmohsin7
Copy link
Member

Maybe let users check-in once a day to log multiple entries of them visiting the same monument. So the check-in state should reset every 24 hours. Let's wait for appwrite migration to implement this? Since firebase functions aren't free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Monument Check-out Functionality(desktop)

2 participants