Fix mac wheels #749
Merged
Fix mac wheels #749
+32
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stnava if you get a chance would you mind seeing if this branch can be pip installed on your arm64 Mac? I tried to get cmake to find the correct SDK paths without hard coding, so that the x86 and arm64 runners can build again |
|
Verified that this builds on arm64 with help from @caugolm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix build errors by setting
CMAKE_OSX_SYSROOTdynamically.Hard-coded paths to
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdkbreak the runners, which use XCode rather than the command line tools.@stnava would you mind testing if this solves your local build problems? Thanks