Doc: Compute Pure SoA Layout #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an explicit and GPU/CPU portable example to compute on the new, pure SoA particle layout.
ax3l
added
component: documentation
ax3l
commented
Feb 2, 2024
Comment on lines
+391
to
+392
| .def("InitRandomPerBox", py::overload_cast<Long, ULong, const ParticleInitData&>(&ParticleContainerType::InitRandomPerBox)) | ||
| .def("InitOnePerCell", &ParticleContainerType::InitOnePerCell) |
There was a problem hiding this comment.
@atmyers can you potentially add InitRandomPerBox and InitOnePerCell for the pure SoA layout in AMReX?
There was a problem hiding this comment.
I tried it here, but would like to abandon at least the InitRandomPerBox one for a fresh try, since your InitRandom implementation was merged:
AMReX-Codes/amrex#3280
ax3l
force-pushed
the
doc-compute-pure-soa
branch
3 times, most recently
from
9e54910 to
d4242a2
Compare
ax3l
force-pushed
the
doc-compute-pure-soa
branch
from
d4242a2 to
58be049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParticleInitDatafor PureSoA