Skip to content

Conversation

@AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Aug 18, 2025

Summary

In C++ it is not allowed to make a zero-sized array type like int[0] so a more verbose way using amrex::TypeArray<int, 0> needs to be used. Additionally, std::declval is now used instead of Types{}.

Additional background

Zero-variants in BLAST-ImpactX/impactx#1104

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l requested a review from WeiqunZhang August 18, 2025 20:36
@ax3l ax3l added the bug label Aug 18, 2025
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yay!

@WeiqunZhang WeiqunZhang merged commit d9ec344 into AMReX-Codes:development Aug 19, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants