Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
halo_component_thresholdandhalo_extrema_thresholdare now being read in, and passed into Reeber.Util/reeber/src/reeber.cpp. Ideally, Reeber should be a git submodule, which will be done in a later PR.Exec/HaloFinder. Note that the IC file list should be supplied through a text file specified in the inputs with the variablenyx.binary_particle_file.Source/IO/Nyx_output.cpphas the routines.Output. Output is turned off by default. Options are provided in theinputsto write the output -nyx.write_lightcones_and_halos_vtkandnyx.write_lightcones_and_halos_simplebinaryRead_SimpleBinary_Halos.pyandRead_SimpleBinaryLightcones.pyare included inExec/HaloFinder- this can read the simple binary file output for halos and lightcones.Attached images show the lightcone shells (gray) and halo locations within the shell (red) at
z=5.59andz=0.99for a128x128x128mesh size run, withhalo_comp_threshold=3.0andhalo_extrema_threshold=8.0(just for testing). The domain box is shown as well.