Enhance password validation logic in keystore#3
Open
just-a-boy wants to merge 1 commit into
Open
Conversation
## Bug description When `nitron keystore` asks for password confirmation, the validator for `passwordConfirm` expects `values.password` to exist. But with the installed `prompts` version, the `validate` callback only receives the current value, not the full answers object. So `values.password` is `undefined`, causing the confirm check to fail even when both entries match. ### Result - `Keystore password` accepts a valid password - `Confirm password` rejects it with `Passwords do not match` - The bug is in `src/keystore.ts` validation logic ### Fix Store the first password in a local variable when the user enters it, then compare the confirmation against that stored value instead of `values.password`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
When
nitron keystoreasks for password confirmation, the validator forpasswordConfirmexpectsvalues.passwordto exist.But with the installed
promptsversion, thevalidatecallback only receives the current value, not the full answers object. Sovalues.passwordisundefined, causing the confirm check to fail even when both entries match.Result
Keystore passwordaccepts a valid passwordConfirm passwordrejects it withPasswords do not matchsrc/keystore.tsvalidation logicFix
Store the first password in a local variable when the user enters it, then compare the confirmation against that stored value instead of
values.password.