[CRITICAL] Fix: Prevent RCE via Unsafe Code Execution in No-Op Sandbox#389
Open
aditya072690 wants to merge 1 commit intoAIxBlock-2023:mainfrom
Open
[CRITICAL] Fix: Prevent RCE via Unsafe Code Execution in No-Op Sandbox#389aditya072690 wants to merge 1 commit intoAIxBlock-2023:mainfrom
aditya072690 wants to merge 1 commit intoAIxBlock-2023:mainfrom
Conversation
- Force SANDBOX_CODE_ONLY mode in production environments - Require explicit ALLOW_UNSANDBOXED flag for unsafe modes in development - Add security warnings for unsafe execution modes - Default to safe sandbox if unsafe mode detected without flag This fixes a critical RCE vulnerability where user-provided code could execute with full Node.js process privileges when AP_EXECUTION_MODE is set to UNSANDBOXED or SANDBOXED. CVSS Score: 9.8 (Critical) Severity: Critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
This PR fixes a critical RCE vulnerability where user-provided code could execute with full Node.js process privileges.
Changes
SANDBOX_CODE_ONLYmode in productionALLOW_UNSANDBOXEDflag for unsafe modesSecurity Impact
Testing
References
aditya072690:bugfix/critical-rce-noop-sandbox