Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the result of innerMaterial() and outerMaterial() depending on if the other is called first #1414

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Mar 7, 2025

BEGINRELEASENOTES

  • Fix the result of innerMaterial() and outerMaterial() depending on if the other is called first
  • Add a test that fails without this fix and passes with the fix

ENDRELEASENOTES

Fix #1413.

I don't know exactly why this is happening for a few surfaces. What happens is that when getting the next boundary after innerMaterial() has been called is not the same as if it wasn't called (in this call

TGeoNode * node2 = _tgeoMgr->FindNextBoundaryAndStep( 500, 1) ;
). Making a backup of the navigator and restoring it solves this problem.

This prevents `innerMaterial()` and `outerMaterial()` to give different
results when the other function is called first.
@andresailer
Copy link
Member

Thanks! That was a nice big piece of debugging!

@andresailer
Copy link
Member

@MarkusFrankATcernch

We have a failing seed for the box of straws test here

  EventSeeder1     INFO  At beginEvent: eventID=0, runID=0 initialSeed=1960713805, newSeed=3837709546

Copy link

github-actions bot commented Mar 7, 2025

Test Results

   16 files     16 suites   6h 5m 51s ⏱️
  371 tests   370 ✅ 0 💤 1 ❌
2 895 runs  2 894 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 47a6e2b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The result of innerMaterial and outerMaterial depends on if the other function is called before
2 participants