Skip to content

Add WalletDb Initialization to StorageNode::new() in src/storage.rs #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sophie-Ag00001
Copy link
Collaborator

PR Description: Add WalletDb Initialization to StorageNode::new()

Summary of Changes

This pull request implements the initialization of a new WalletDb instance within the StorageNode::new() function located in src/storage.rs. This modification mirrors the existing WalletDb initialization found in src/miner.rs.

Motivation

The primary motivation for these changes is to ensure a consistent initialization procedure for the WalletDb across different components of the application, particularly enhancing the management and accessibility of wallet-related data within the storage node.

Relevant Context

The WalletDb serves a critical role in managing wallet data, and its appropriate initialization within the StorageNode will enable better data integrity and retrieval processes. Aligning the initialization across modules also fosters code consistency and maintainability.

Testing Instructions

  1. Pull the branch containing this PR.
  2. Build the project to ensure there are no compilation errors.
  3. Run the existing unit tests and integration tests to verify that the StorageNode operates as expected with the new WalletDb initialization.
  4. Test the wallet functionality in the application to ensure proper interactions with the WalletDb.

Known Issues / Limitations

  • There are no known issues associated with this change at this time.
  • As per the user request, no other files outside of src/storage.rs were modified.

Thank you for your consideration! Looking forward to your feedback.

…Node::new() function in src/storage.rs, similar to the WalletDb initialization in src/miner.rs. ONLY WORK ON src/storage.rs, NO OTHER FILES. DO NOT DELETE ANY CODE OR FILES.
@Sophie-Ag00001 Sophie-Ag00001 requested a review from a team as a code owner January 15, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants