Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios) Display FinalWallet balance on HomeScreen #667

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

robbiehanson
Copy link
Contributor

If the user has funds in their FinalWallet, that information is now included in the "incoming balance" information on the HomeScreen. Also, tapping that balance will now show a popover that mirrors recent changes on Android:

Also added a badge for the HomeScreen that counts in-flight payments (mirrors Android UI changes in #522 ):

@dpad85
Copy link
Member

dpad85 commented Jan 10, 2025

Note, the pendingChannelsBalance coming from the BalanceManager is going to be removed in the database migration update. It's not useful anymore, it's always 0 since the new on-the-fly funding mechanism (ACINQ/lightning-kmp#649) which circumvents the issue altogether. So we'll soon be able to clean up some code.

@dpad85
Copy link
Member

dpad85 commented Jan 17, 2025

Nitpick, I think the popover would look better if the background was gray and the buttons white.

@robbiehanson robbiehanson force-pushed the ios-final-wallet-balance branch from 0d0b2ca to a654653 Compare January 17, 2025 19:48
@robbiehanson robbiehanson force-pushed the ios-final-wallet-balance branch from a654653 to 5e6b4f1 Compare February 11, 2025 19:55
@robbiehanson
Copy link
Contributor Author

Updated colors:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants