Upgrade to Kotlin 2.1.10 #654
Conversation
|
Note, to manage dependency versions we also switched to the toml version catalog instead of the |
dpad85
force-pushed
the
kotlin-2.0-alt-direct-integ
branch
from
d17a751 to
083af38
Compare
dpad85
force-pushed
the
kotlin-2.0-alt-direct-integ
branch
from
083af38 to
1444d0d
Compare
dpad85
force-pushed
the
kotlin-2.0-alt-direct-integ
branch
from
1444d0d to
92caf39
Compare
This script is not necessary anymore, as the framework copying is already done.
Also removed Tor helper method.
dpad85
force-pushed
the
kotlin-2.0-alt-direct-integ
branch
from
92caf39 to
1c338cb
Compare
These workaround should be now fixed with kotlin 2.
- secp: 0.14.0 -> 0.17.1 - ktor: 2.3.13 -> 3.1.0 A few androidx libraries have also been updated.
| @@ -647,7 +647,6 @@ class CurrencyManager( | |||
| // | |||
| val http = HttpClient { | |||
| engine { | |||
| threadsCount = 1 | |||
There was a problem hiding this comment.
@robbiehanson This option has been deprecated at the error level and should not be used anymore, they recommend to use dispatcher instead. But the whole issue may have been fixed altogether in a previous version ? This needs some investigation.
There was a problem hiding this comment.
Yes, it looks like the original issue was fixed in Ktor v2.0.2. From the release notes:
"Darwin engine: Client connection is closed after each request (KTOR-4145)"
Which was similar to the issue that I reported in KTOR-3362
Also, in investigating this I discovered that api.coindesk.com appears to be completely shutdown. As in, I don't even see a DNS entry for it anymore. I'll create a new ticket for it.
dpad85
force-pushed
the
kotlin-2.0-alt-direct-integ
branch
from
f4154ae to
c246351
Compare
Some UI elements have been broken with this updated and need to be fixed.
This PR upgrades the project to Kotlin 2. It supersedes #628.
We also switch to the direct integration technique which is the standard and also fixes a build issue on some Xcode versions.