Performance improvements to Physics.Common.WeenieObject#4212
Open
FlaggAC wants to merge 1 commit intoACEmulator:masterfrom
Open
Performance improvements to Physics.Common.WeenieObject#4212FlaggAC wants to merge 1 commit intoACEmulator:masterfrom
FlaggAC wants to merge 1 commit intoACEmulator:masterfrom
Conversation
Entire set of fields can be marked as readonly, as it never changes outside of the constructor. Reduces unnecessary reflection operations by pre-fetching them during constructor Changes WeenieObject to a sealed class to guarantee immutability Immutability allows a shared DummyObject to be used by PhysicsObjs which do not have a weenie.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire set of fields can be marked as readonly, as it never changes outside of the constructor.
Reduces unnecessary reflection operations by pre-fetching them during constructor
Changes WeenieObject to a sealed class to guarantee immutability
Immutability allows a shared DummyObject to be used by PhysicsObjs which do not have a weenie.
The reflection calls are made frequently by
PhysicsObj.FindObjCollisions(Transition), which is a very frequently-called method, so this is expected to improve performance. The 'is' operator is fast by reflection standards, but there is still some overhead with it, which should not be ignored considering the high frequency of the method calls.ID and UpdateTime are commented out because they are never used.