This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Fix garbage collection of script callbacks on macOS. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the `NSBlock` was garbage collected before the task completed. That's because the method elided the `async`/`await` keywords. For more information see https://blog.stephencleary.com/2016/12/eliding-async-await.html.
bddckr
force-pushed
the
bug/garbage-collection-script-callback-macos
branch
from
0f62be6 to
1bee87b
Compare
bddckr
changed the title
Contributor
Author
|
This doesn't actually resolve the issue for all occurrences. I believe this simply changed the timing in my favor enough for it to no longer reproduce on my machine. However, on macOS Ventura, this issue still reliably reproduces. I opened #32, which is unrelated, but turns out to fix this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
NSBlockwas garbage collected before the task completed. That's because the method elided theasync/awaitkeywords. For more information see https://blog.stephencleary.com/2016/12/eliding-async-await.html.