ci: fix failing udeps install due to rust nightly #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9oelM
force-pushed
the
ci/udeps-install-fix
branch
from
179e128 to
cd18284
Compare
9oelM
changed the title
xJonathanLEI
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: starting from
nightly-2023-06-28, Rust nightly changed the name of a preview feature, andproc-macro2is referring to that feature that does not exist anymore. More about this problem at: rust-lang/rust#113152cargo-udeps is using an old version of
proc-macro2which is 1.0.59. The problem is fixed in versions higher than 1.0.59. But obviously we need cargo-udeps to have it updated. So it will take some time for them to work on this problem. I just submitted an issue to their repo as well: est31/cargo-udeps#180.What we can do for now, to get the CI working so that we can just work, is to anchor the nightly version at
nightly-2023-06-27and wait for the fix, and revert to the latest version of nightly after the fix. I already tested with my own repo and confirmed it works withnightly-2023-06-27and fails with versions after that: