feat(api)!: Make SignKM accept generic crypto.Signer - #392
Closed
werwurm wants to merge 2 commits into
Closed
Conversation
werwurm
requested review from
ArthurHeymans,
ChriMarMe,
PatrickRudolph,
walterchris and
zaolin
as code owners
September 6, 2024 21:39
Contributor
Author
|
I realize that this changes the API. It could be hidden by adding new API, e.g., Also, to really make use of this change, the fiano back end needs to be changed. Which I have proposed here [1] [2] |
walterchris
approved these changes
Sep 7, 2024
walterchris
left a comment
walterchris
left a comment
Collaborator
There was a problem hiding this comment.
I think changing the API here is fine.
Collaborator
|
Could you satisfy the linter? :) |
werwurm
changed the title
werwurm
changed the title
Accepting crypto.PrivateKey uneccessarily restricts this library to software crypto algorithms provided by the golang crypto packages. By allowing the more generic crypto.Signer interface alternative implementations, e.g., backed by HSMs, can be supported. Signed-off-by: Janis Danisevskis <jdanisevskis@aurora.tech>
werwurm
force-pushed
the
generic_crypto_signer
branch
from
September 9, 2024 16:11
318545e to
6702af9
Compare
Contributor
Author
Sure thing. I hope this fixes it. commitlint is new to me. So bare with me, please. |
Collaborator
|
We will rebase and cherry pick the commits - so no squash here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting crypto.PrivateKey uneccessarily restricts this library to software crypto algorithms provided by the golang crypto packages. By allowing the more generic crypto.Signer interface alternative implementations, e.g., backed by HSMs, can be supported.