Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CMake script macOS-compatible #30

Closed
wants to merge 2 commits into from

Conversation

OPNA2608
Copy link

Closes #13

@8bitbubsy
Copy link
Owner

  1. Does it work on both Intel Mac and ARM mac?
  2. MAXOSX_CORE?

@OPNA2608
Copy link
Author

OPNA2608 commented Feb 10, 2022

  1. I only have access to an Intel Mac, and it seems to work fine there. (I'm seeing some problems with the program on it but I don't think they're related to these settings)
  2. Needed by RtMidi to enable CoreMIDI support, though I don't have any hardware available to test the functionality

@8bitbubsy
Copy link
Owner

  1. I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.
  2. Let me try again. :) MAXOSX_CORE? MACOSX_CORE!

@OPNA2608
Copy link
Author

Whoops! 😅

@fgaz
Copy link

fgaz commented Feb 10, 2022

I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.

@OPNA2608 We could try with the nixos builders

@ghost
Copy link

ghost commented Aug 7, 2022

I have an M1 Mac Mini we could test on!

@KAMiKAZOW
Copy link

I have an M1 Mac Mini we could test on!

And?

@OPNA2608
Copy link
Author

I'm not going to add this if it doesn't compile on ARM Macs

@OPNA2608 We could try with the nixos builders

Tested on aarch64-darwin via Nixpkgs CI test infrastructure: https://logs.ofborg.org/?attempt_id=663979be-7320-42cc-8225-1daf801410e7&key=nixos%2Fnixpkgs.250732 , aarch64-darwin_ft2-clone_cmake-patch.log.txt

@fgaz
Copy link

fgaz commented Sep 26, 2023

@8bitbubsy ping! This patch has been working well in our builds https://hydra.nixos.org/job/nixpkgs/trunk/ft2-clone.aarch64-darwin

@8bitbubsy
Copy link
Owner

8bitbubsy commented Sep 26, 2023

I fixed CMakeLists.txt in the latest commit. Please let me know if it works @fgaz and @OPNA2608.
EDIT: Remember to remove any old patches!

@fgaz
Copy link

fgaz commented Oct 5, 2023

It works, thank you!

NixOS/nixpkgs#259155

@OPNA2608 OPNA2608 closed this Oct 5, 2023
@OPNA2608 OPNA2608 deleted the macos_cmake branch October 5, 2023 16:51
@JoNilsson
Copy link

It works, thank you!

NixOS/nixpkgs#259155

This is awesome! I've just recently become somewhat obsessed with NixOS!

I'm especially interested in seeing if the builds for aarch64 will work! I'm running NixOS on Nvidia Jetson AGX Orin and would love to include FT2 as an essential in my NixOS configuration!

@OPNA2608
Copy link
Author

OPNA2608 commented Oct 5, 2023

The aarch64 build works on my PineBook Pro running NixOS FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CMakeLists.txt work on mac os too
5 participants